Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FS-4942 : adding code reload once started the app using dev, and once done any change into TypeScript, this will be recompiled and re-started. #99

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

nuwan-samarasinghe
Copy link
Collaborator

Ticket: https://mhclgdigital.atlassian.net/browse/FS-4942

Change description

adding code reload once started the app using dev, and once done any change into TypeScript, this will be recompiled and re-started.

Copy link
Collaborator

@wjrm500 wjrm500 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is just for debugging Runner right - can we do Designer as well?

Separate question: do we need a yarn.lock file in the designer/ and runner/ subdirectories?

Also, please do try to provide more detail in PR descriptions, including explanation of changes (e.g., what is concurrently?) and testing / usage instructions. Makes it much easier to review :)

@nuwan-samarasinghe
Copy link
Collaborator Author

  1. Designer We already using the code watcher which compiles every time once do a change
"watch": "NODE_ENV=development webpack",
 "dev": "NODE_OPTIONS=--openssl-legacy-provider && concurrently 'yarn watch' 'yarn start:local'",
  1. In node projects if we created it as
"workspaces": [
    "model",
    "runner",
    "designer",
    "digital-form-builder/model",
    "digital-form-builder/queue-model",
    "digital-form-builder/designer",
    "digital-form-builder/runner",
    "digital-form-builder/e2e",
    "e2e-test"
  ],

it will not create separate lock file

  1. documentation if needed -> run multiple commands concurrently like in java threads

@nuwan-samarasinghe nuwan-samarasinghe enabled auto-merge (squash) January 3, 2025 13:31
…done any change into TypeScript, this will be recompiled and re-started.

adding code reload once started the app using dev, and once done any change into TypeScript, this will be recompiled and re-started.

adding designer debugger
@nuwan-samarasinghe nuwan-samarasinghe force-pushed the FS-4942-runner-code-reload-once-change branch from ac4e058 to 8b134c7 Compare January 7, 2025 16:44
Copy link

sonarqubecloud bot commented Jan 7, 2025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants