Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fs 3061 - client side file upload component #429

Merged
merged 14 commits into from
Dec 4, 2023

Conversation

AbuNavsa
Copy link

@AbuNavsa AbuNavsa commented Dec 2, 2023

Add client side file upload component

Changes

  • Added ClientSideFileUploadField to component types and created edit screen in designer, using FreeTextField as an example.
  • Tested in the designer locally, both generating a form, downloading it and opening in the runner, and also importing a COF form that uses ClientSideFileUploadField-
  • Test files are currently unrunnable so test cases do not run correctly due to missing dependancies.

How Has This Been Tested?

I have tested this manually and compared with other components to see the similarities. Have tested the upload and uploads successfully

TO DO - (Tickets to be made for)

  • Make the accepted files more user friendy in the edit page, currently is a string/text input but perhaps checkboxes or similar to select the accepted files
  • Create tests once test cases can be run

Screenshots

image

image

image

@AbuNavsa AbuNavsa changed the title initial commit Fs 3061 - client side file upload component Dec 3, 2023
@AbuNavsa AbuNavsa self-assigned this Dec 3, 2023
Copy link

@adamdavies1 adamdavies1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AbuNavsa AbuNavsa merged commit 6006184 into main Dec 4, 2023
11 of 12 checks passed
@AbuNavsa AbuNavsa deleted the FS-3061-ClientSideFileUploadV3 branch December 4, 2023 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants