Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FS-3797 workflow #430

Merged
merged 5 commits into from
Dec 5, 2023
Merged

FS-3797 workflow #430

merged 5 commits into from
Dec 5, 2023

Conversation

robk-dluhc
Copy link

Description

Amend AWS copilot workflows so they run sequentially rather than concurrently, each relying on the one before, and use the correct concurrency rule to avoid restarting services simultaneously.

aaronwilliamsv1
aaronwilliamsv1 previously approved these changes Dec 4, 2023
Copy link

@aaronwilliamsv1 aaronwilliamsv1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

@srh-sloan srh-sloan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for now, but I think there's probably a cleaner way of doing this without the duplication and to make the graph of a running job easier to read.

@robk-dluhc robk-dluhc merged commit dcd6429 into main Dec 5, 2023
11 of 12 checks passed
@robk-dluhc robk-dluhc deleted the FS-3797-workflow branch December 5, 2023 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants