Skip to content

Commit

Permalink
EC-54 Document faulty test from python to report
Browse files Browse the repository at this point in the history
  • Loading branch information
kpinakula committed Oct 17, 2024
1 parent 38676ee commit 17ff1ea
Showing 1 changed file with 11 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -76,11 +76,15 @@ fn check_heatnetwork_present(input: &InputForProcessing) -> bool {

/// Apply notional lighting efficacy
/// efficacy = 120 lm/W
fn edit_lighting_efficacy(input: &mut InputForProcessing) -> () {
fn edit_lighting_efficacy(input: &mut InputForProcessing) {
let lighting_efficacy = 120.0;
input.set_lighting_efficacy_for_all_zones(lighting_efficacy);
}

fn edit_opaque_ajdztu_elements(input: &mut InputForProcessing) {
todo!()
}

/// Calculate effective air change rate accoring to according to Part F 1.24 a
pub fn minimum_air_change_rate(
_input: &InputForProcessing,
Expand Down Expand Up @@ -164,4 +168,10 @@ mod tests {
)
}
}

#[ignore = "this test is not correct in Python so has not been ported"]
#[rstest]
fn test_edit_opaque_ajdztu_elements() {
todo!("Implement once equivalent python test is fixed. Currently it always passes but no assertions are actually reached and run because of logic that compares pitch (int) to a HeatFlowDirection (enum) and a missing else block.")
}
}

0 comments on commit 17ff1ea

Please sign in to comment.