FS-4004: Preload AssessmentRecord properties and compress response #479
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ksp37-dluhc
force-pushed
the
FS-4004-optimise-application-overviews-endpoint
branch
from
a67570d
to
0919c4d
Compare
nuwan-samarasinghe
approved these changes
Jun 13, 2024
Adam-W1
reviewed
Jun 13, 2024
added 2 commits
June 14, 2024 09:44
ksp37-dluhc
force-pushed
the
FS-4004-optimise-application-overviews-endpoint
branch
from
0919c4d
to
1ff1e69
Compare
Adam-W1
approved these changes
Jun 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements two changes to the applications_overview endpoint:
Avoids N+1 queries by preloading related data for AssessmentRecord
Compresses the response from the applications_overview endpoint by using minified json.
Unit tests and other appropriate tests added or updated
README and other documentation has been updated / added (if needed)
Commit messages are meaningful and follow good commit message guidelines (e.g. "FS-XXXX: Add margin to nav items preventing overlapping of logo")
How to test
Observe load time in test environment
Screenshots of UI changes (if applicable)