FS-4446: Consistent CSV File Columns #500
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfount
reviewed
Sep 24, 2024
There was a problem hiding this comment.
Looks good, a subtle difference but looks like one that could crop up for users at anytime!
The description on the PR is really helpful context on why that order might have been shifted, if that could be added to the commit description itself that should help any future devs outside of GitHub looking at why that might have changed.
suegarner
force-pushed
the
FS-4446-ConsistentCSVColumns
branch
from
fa7b0c7
to
0db45e4
Compare
suegarner
force-pushed
the
FS-4446-ConsistentCSVColumns
branch
from
0db45e4
to
a12c467
Compare
sfount
reviewed
Sep 26, 2024
Rearranged the default order of the columns so that Score comes directly after Date submitted regardless whether there is a score entered or not. Previously Score and Score Subcriteria could be swapped depending on if the first row had been scored yet)
Changed so that the report remains in the same order regardless if applications have been scored or not
For the OUTPUT_TRACKER report, the test checks the column order in a report of unscored applications against the column order in a report of scored applications. The scored report will have more columns so we're comparing all the columns in the unscored report against the first x columns in scored report.
suegarner
force-pushed
the
FS-4446-ConsistentCSVColumns
branch
from
bc86022
to
74e0173
Compare
for more information, see https://pre-commit.ci
srh-sloan
approved these changes
Sep 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FS-446
Change description
Rearranged the default order of the columns so that Score comes directly after Date submitted regardless whether there is a score entered or not. Previously Score and Score Subcriteria could be swapped depending on if the first row had been scored yet)
README and other documentation has been updated / added (if needed)How to test
Open OUTPUT_TRACKER report for a window that has applications but no scores. Open OUTPUT_TRACKER for a window that has applications and are all scored. The columns should be in the same order for both reports.
Screenshots of UI changes (if applicable)
Before fix (COF OUTPUT_TRACKER report):
NSTF OUTPUT_TRACKER report:
