Skip to content
This repository has been archived by the owner on Dec 18, 2024. It is now read-only.

Commit

Permalink
Merge pull request #352 from communitiesuk/readme-cleanup-approvals
Browse files Browse the repository at this point in the history
BAU: reflect updated approval process
  • Loading branch information
gidsg authored Nov 7, 2024
2 parents 76b3339 + b3434d8 commit c57257a
Showing 1 changed file with 1 addition and 5 deletions.
6 changes: 1 addition & 5 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -61,8 +61,4 @@ Copilot is used for infrastructure deployment. Instructions are available [here]
- image-name: funding-service-design-authenticator

# Pull Requests
Authenticator has a different set of requirements for PR reviewers, as it is relied upon by multiple services (pre-award and post-award). It requires a minimum of 2 reviewers to approve a PR before merge, and will auto-request a review from the following 2 teams when a PR is raised:
- fsd-post-award-deployers
- fsd-pre-award-deployers
These teams are configured in the [CODEOWNERS](./.github/CODEOWNERS) file.
Github cannot enforce the 2 reviews coming from 2 different teams, so please make sure you have 2 appropriate reviews before merging.
Authenticator has a different set of requirements for PR reviews, as it is relied upon by multiple services. It requires a minimum of 2 reviewers to approve a PR before merging.

0 comments on commit c57257a

Please sign in to comment.