Skip to content
This repository has been archived by the owner on Dec 18, 2024. It is now read-only.

Read fund-store host from parameter store #361

Merged
merged 1 commit into from
Nov 20, 2024

Conversation

samuelhwilliams
Copy link
Contributor

Change description

This will help us migrate from the "microservice"-y fund-store to a more consolidated pre-award-stores service.

Ticket: https://mhclgdigital.atlassian.net/browse/FSPT-108

@gidsg
Copy link
Contributor

gidsg commented Nov 20, 2024

Can we add a TODO to switch this back post migration?

@samuelhwilliams
Copy link
Contributor Author

samuelhwilliams commented Nov 20, 2024

I can do, if you insist - although I don't think we need a TODO, for two reasons:

  • Why do we need to switch it back? This approach seems OK, if not preferrable? Configuration should maybe be configuration, not code - 12 factor app stuff?
  • We're probably planning to remove the API altogether anyway?

This will help us migrate from the "microservice"-y fund-store to a more
consolidated pre-award-stores service.

Ticket: https://mhclgdigital.atlassian.net/browse/FSPT-108
@samuelhwilliams samuelhwilliams force-pushed the bau/fund-store-api-host-from-env-var branch from 584a95a to 18cfb63 Compare November 20, 2024 11:58
@samuelhwilliams samuelhwilliams merged commit 52aec59 into main Nov 20, 2024
14 checks passed
@samuelhwilliams samuelhwilliams deleted the bau/fund-store-api-host-from-env-var branch November 20, 2024 12:24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants