Skip to content
This repository has been archived by the owner on Jul 25, 2024. It is now read-only.

[BAU] use isort black profile to prevent pre-commit conflict #53

Merged
merged 1 commit into from
Aug 2, 2023
Merged

[BAU] use isort black profile to prevent pre-commit conflict #53

merged 1 commit into from
Aug 2, 2023

Conversation

cyrusdobbs
Copy link
Contributor

Change description

Configures isort to use a configuration that doesn't conflict with black

  • Unit tests and other appropriate tests added or updated
  • README and other documentation has been updated / added (if needed)
  • Commit messages are meaningful and follow good commit message guidelines (e.g. "FS-XXXX: Add margin to nav items preventing overlapping of logo")

How to test

If manual testing is needed, give suggested testing steps

Screenshots of UI changes (if applicable)

nsnape
nsnape approved these changes Aug 2, 2023
View reviewed changes
Copy link

@nsnape nsnape left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cyrusdobbs cyrusdobbs merged commit b72b87e into main Aug 2, 2023
1 check passed
@cyrusdobbs cyrusdobbs deleted the fix/isort-black-pre-commit-conflict branch August 2, 2023 13:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@nsnape nsnape nsnape approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cyrusdobbs @nsnape