BAU: Update redirect #168
Merged
BAU: Update redirect #168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| response = make_response( | ||
| redirect(request.referrer or request.args.get("return_url") or "/", 302) | ||
| ) | ||
| response = make_response(redirect(request.referrer or "/", 302)) |
Check warning
Code scanning / CodeQL
URL redirection from remote source Medium
Show autofix suggestion
Hide autofix suggestion
Copilot Autofix AI 13 days ago
To fix the problem, we need to validate the request.referrer before using it in the redirect function. We can use the urlparse function from the Python standard library to ensure that the referrer does not include an explicit host name, making it a relative path. This will prevent redirection to external sites. If the referrer is not valid, we will redirect to the home page (/).
Suggested changeset
1
fsd_utils/locale_selector/set_lang.py
| @@ -35,4 +35,10 @@ | ||
| def select_language(locale): | ||
| # TODO: Perform additional validation on referrer | ||
| response = make_response(redirect(request.referrer or "/", 302)) | ||
| from urllib.parse import urlparse | ||
| # Validate referrer to ensure it does not include an explicit host name | ||
| referrer = request.referrer or "/" | ||
| referrer = referrer.replace('\\', '') | ||
| if not urlparse(referrer).netloc and not urlparse(referrer).scheme: | ||
| response = make_response(redirect(referrer, 302)) | ||
| else: | ||
| response = make_response(redirect("/", 302)) | ||
| LanguageSelector.set_language_cookie(locale, response) |
Copilot is powered by AI and may make mistakes. Always verify output.
gidsg
force-pushed
the
bau-update-redirect
branch
from
7ddd825
to
f257749
Compare
samuelhwilliams
previously approved these changes
Sep 26, 2024
ksp37-dluhc
reviewed
Sep 26, 2024
ksp37-dluhc
previously approved these changes
Sep 26, 2024
sfount
reviewed
Sep 26, 2024
gidsg
dismissed stale reviews from nuwan-samarasinghe, NarenderRajuB, ksp37-dluhc, and samuelhwilliams
via
b70127d
gidsg
force-pushed
the
bau-update-redirect
branch
from
b70127d
to
bf7c22d
Compare
gidsg
force-pushed
the
bau-update-redirect
branch
from
bf7c22d
to
ca11c46
Compare
ksp37-dluhc
approved these changes
Oct 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change description
See https://communities-govuk.slack.com/archives/C0761EKCM6G/p1727340071395389 for context
How to test
If manual testing is needed, give suggested testing steps
Screenshots of UI changes (if applicable)