Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bugfix/get language cookie- fix sentry errors "UnknownLocaleError locale" #170

Merged
merged 7 commits into from
Oct 17, 2024
Merged

bugfix/get language cookie- fix sentry errors "UnknownLocaleError locale" #170

merged 7 commits into from
Oct 17, 2024

Conversation

NarenderRajuB
Copy link
Contributor

set default language to "en" if language passed in cookie is non supported in FSD.

Change description

  • Unit tests and other appropriate tests added or updated
  • [ x] README.md, CHANGELOG.md and other documentation has been updated / added (if needed)
  • Commit messages are meaningful and follow good commit message guidelines (e.g. "FS-XXXX: Add margin to nav items preventing overlapping of logo")

Manually tested replicating error setting cookie no non-supporting language

image

nuwan-samarasinghe
nuwan-samarasinghe previously approved these changes Oct 15, 2024
View reviewed changes
Copy link
Contributor

@nuwan-samarasinghe nuwan-samarasinghe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

hamzabinkhalid
hamzabinkhalid previously approved these changes Oct 16, 2024
View reviewed changes
Copy link
Contributor

@hamzabinkhalid hamzabinkhalid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

srh-sloan
srh-sloan requested changes Oct 16, 2024
View reviewed changes
fsd_utils/locale_selector/get_lang.py Outdated Show resolved Hide resolved
@NarenderRajuB NarenderRajuB merged commit a778337 into main Oct 17, 2024
6 checks passed
@NarenderRajuB NarenderRajuB deleted the bugfix/get-language-cookie branch October 17, 2024 09:07
@samuelhwilliams samuelhwilliams mentioned this pull request Oct 17, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srh-sloan srh-sloan srh-sloan approved these changes

@nuwan-samarasinghe nuwan-samarasinghe nuwan-samarasinghe left review comments

@hamzabinkhalid hamzabinkhalid hamzabinkhalid left review comments

@samuelhwilliams samuelhwilliams Awaiting requested review from samuelhwilliams

@gidsg gidsg Awaiting requested review from gidsg

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@NarenderRajuB @srh-sloan @gidsg @samuelhwilliams @nuwan-samarasinghe @hamzabinkhalid