Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

attach click event to links in nav bar so that it closes the nav bar … #123

Merged
merged 6 commits into from
Jul 17, 2023
Merged

attach click event to links in nav bar so that it closes the nav bar … #123

merged 6 commits into from
Jul 17, 2023

Conversation

Ellie-Brakoniecki
Copy link
Contributor

@Ellie-Brakoniecki Ellie-Brakoniecki commented Jul 14, 2023 •
edited
Loading

https://trello.com/c/obS5d69m

Pull request checklist

  • Add a descriptive message for this change to the PR
  • Run black ./ locally
  • Run pylint gov_uk_dashboards locally
  • Run python -u -m pytest --headless tests locally
  • Include screenshot for any visual changes
  • Incremented the version in setup.py

PR Description:

  • Make the navbar links close the menu when on a mobile device
  • Also changes to add ids to links in the LG dashboard

kateriley1
kateriley1 approved these changes Jul 17, 2023
View reviewed changes
Copy link
Contributor

@kateriley1 kateriley1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work both :)

@Ellie-Brakoniecki Ellie-Brakoniecki merged commit e971b65 into main Jul 17, 2023
7 checks passed
@Ellie-Brakoniecki Ellie-Brakoniecki deleted the mobile-nav-bar-pckg branch July 17, 2023 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kateriley1 kateriley1 kateriley1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Ellie-Brakoniecki @kateriley1 @urquha