Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

reset filter button has role type button rather than link #132

Merged
merged 2 commits into from
Sep 8, 2023
Merged

reset filter button has role type button rather than link #132

merged 2 commits into from
Sep 8, 2023

Conversation

kateriley1
Copy link
Contributor

@kateriley1 kateriley1 commented Sep 7, 2023 •
edited
Loading

https://trello.com/c/ef5bD5bN/1896-bug-reset-filters-link-changed-to-button

Pull request checklist

  • Add a descriptive message for this change to the PR
  • Run black ./ locally
  • Run pylint gov_uk_dashboards locally
  • Run python -u -m pytest --headless tests locally
  • Include screenshot for any visual changes
  • Incremented the version in setup.py

PR Description:

Fix bug - Reset filters was incorrectly reported as a link to screen reader users. It is now reported as a button.

@kateriley1 kateriley1 merged commit 7bc027e into main Sep 8, 2023
7 checks passed
@kateriley1 kateriley1 deleted the bug-reset-filter-button-is-reported-as-link branch September 8, 2023 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tom-clarke-dluhc tom-clarke-dluhc tom-clarke-dluhc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kateriley1 @tom-clarke-dluhc