Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix pandas warning #134

Merged
merged 1 commit into from
Sep 12, 2023
Merged

Fix pandas warning #134

merged 1 commit into from
Sep 12, 2023

Conversation

tom-clarke-dluhc
Copy link
Contributor

@tom-clarke-dluhc tom-clarke-dluhc commented Sep 12, 2023 •
edited
Loading

Pull request checklist

  • Add a descriptive message for this change to the PR
  • Run black ./ locally
  • Run pylint gov_uk_dashboards locally
  • Run python -u -m pytest --headless tests locally
  • Include screenshot for any visual changes
  • Incremented the version in setup.py

PR Description:

Previously getting the following warning. The suggested change fixes it:

...gov_uk_dashboards\components\plotly\table.py:
78: FutureWarning:

Series.__getitem__ treating keys as positions is deprecated. In a future version, integer keys will always be treated as l
abels (consistent with DataFrame behavior). To access a value by position, use `ser.iloc[pos]`

Patch to 9.16.4

@tom-clarke-dluhc tom-clarke-dluhc merged commit de61d3a into main Sep 12, 2023
7 checks passed
@tom-clarke-dluhc tom-clarke-dluhc deleted the fix-pandas-warning branch September 12, 2023 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robertblincoe robertblincoe robertblincoe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tom-clarke-dluhc @robertblincoe