Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PRSD-649: Landlord Search Page Integration Tests #136

Merged
merged 5 commits into from
Jan 14, 2025
Merged

PRSD-649: Landlord Search Page Integration Tests #136

merged 5 commits into from
Jan 14, 2025

Conversation

isobel-softwire
Copy link
Contributor

No description provided.

JasminConterioSW
JasminConterioSW requested changes Jan 14, 2025
View reviewed changes
Copy link
Contributor

@JasminConterioSW JasminConterioSW left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly good, just wanted to check if the case where there no search results is going to be covered elsewhere, also a suggestion to use a separate data-sql file for the tests so they don't get broken if data-local.sql gets updated!

src/test/kotlin/uk/gov/communities/prsdb/webapp/integration/SearchRegisterTests.kt Outdated Show resolved Hide resolved
@isobel-softwire isobel-softwire merged commit 5e1cb39 into main Jan 14, 2025
1 check passed
@isobel-softwire isobel-softwire deleted the feat/PRSD-649-landlord-search-page-tests branch January 14, 2025 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JasminConterioSW JasminConterioSW JasminConterioSW approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@isobel-softwire @JasminConterioSW