Feat/prsd 702 view landlord registered property details #139
+324
−46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isobel-softwire
requested changes
Jan 15, 2025
src/main/kotlin/uk/gov/communities/prsdb/webapp/helpers/LocalAuthorityDataHelper.kt
Show resolved
Hide resolved
...main/kotlin/uk/gov/communities/prsdb/webapp/models/dataModels/RegisteredPropertyDataModel.kt
Show resolved
Hide resolved
| <td class="govuk-table__cell govuk-!-width-one-quarter" th:text="${property.localAuthorityName}"></td> | ||
| <td class="govuk-table__cell govuk-!-width-one-quarter" th:text="${property.propertyLicence}"></td> | ||
| <td class="govuk-table__cell govuk-!-width-one-quarter" th:text="#{${property.isTenanted}}"></td> | ||
| </tr> |
There was a problem hiding this comment.
Do we know if fixed-length columns are the desired behaviour?
There was a problem hiding this comment.
Good Q, it looked that way to me in the design but I might be interpreting it wrong, I'll check
There was a problem hiding this comment.
I had a chat with Sam H about this, we agreed that the columns should have a fixed width.
We also discussed adding spacing between the columns if possible within GDS - I'll look into that now
src/main/kotlin/uk/gov/communities/prsdb/webapp/services/PropertyOwnershipService.kt
Show resolved
Hide resolved
src/test/kotlin/uk/gov/communities/prsdb/webapp/services/PropertyOwnershipServiceTests.kt
Show resolved
Hide resolved
src/test/kotlin/uk/gov/communities/prsdb/webapp/services/PropertyOwnershipServiceTests.kt
Show resolved
Hide resolved
src/main/kotlin/uk/gov/communities/prsdb/webapp/services/PropertyOwnershipService.kt
Show resolved
Hide resolved
src/main/kotlin/uk/gov/communities/prsdb/webapp/constants/enums/LicensingType.kt
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added Registered Properties table to Landlord Record page in the Registered properties tab
Created a query to the Landlord's properties details from the db (this has been manually tested)
Created a method to filter and format the returned data for it to be rendered in the view (I've added unit tests)
Added and populated the table in
landlordDetailsView.htmlConsiderations
There are two things that need fixing for this branch but thought it was worth raising the PR in the mean time.
There aren't any integration tests I plan to add some
The column width in the table is not fixed and is changing dependant on values - Being addressed in comments