Skip to content

Conversation

@JasminConterioSW
Copy link
Contributor

@JasminConterioSW JasminConterioSW commented Oct 28, 2025

Ticket number

PRSD-1519

Goal of change

Update form pages with content before the form components (inputs, submit button) to use the complexQuestionPage fragment (extra content not included in the form)

Description of main change(s)

  • Update form pages with content before the form components (inputs, submit button) to use the complexQuestionPage fragment (extra content not included in the form)
  • Updated ids on the question pages so that id=main-content appears on the <main> section (so it can be found by the "skip to main content" accessiblity link
  • Updated design on Beta Feedback page and EPC Expiry date page to be closer to GDS (question is styled as a medium heading)
    • Also added an aria label to the text area here as the original label is now a legend
  • Updated design on EPC Lookup page so that the information after the button is in a details fragment
image image image

Anything you'd like to highlight to the reviewer?

This looks like a large review but a lot of the files have been changed in a similar way:

  • Use complexQuestionPage.html fragment instead of the questionPage.html fragment
  • Move extra information that isn't asking for a user input to a question-content block
  • Include the inputs / submit buttons in aa form-content block - only these elements will then be in the section

Follows the example of the "Interview needs" question page on the design system.
The same pattern is also used in "Check answers" pages on the the design system

Checklist

Delete any that are not applicable, and add explanation below for any that are applicable but haven't been done

  • Screenshots of any UI changes have been added
  • Test suite has been run in full locally and is passing
  • Branch has been rebased onto main and run locally, with everything working as expected (both for your new feature
    and any related functionality)
  • TODO comments referencing this JIRA ticket have been searched for and removed - if a future PR will address them,
    mention that here

@JasminConterioSW JasminConterioSW marked this pull request as ready for review October 29, 2025 10:32
Copy link
Collaborator

@Travis-Softwire Travis-Softwire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few Qs, but LGTM :) Might want to wait to merge until Azure is back up though, as the pipeline will fail otherwise

@JasminConterioSW JasminConterioSW added this pull request to the merge queue Nov 3, 2025
Merged via the queue into main with commit 071172a Nov 3, 2025
2 checks passed
@JasminConterioSW JasminConterioSW deleted the chore/prsd-1519-use-complex-question-page-fragment branch November 3, 2025 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants