-
Notifications
You must be signed in to change notification settings - Fork 1
Chore/prsd 1519 use complex question page fragment #832
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
JasminConterioSW
merged 48 commits into
main
from
chore/prsd-1519-use-complex-question-page-fragment
Nov 3, 2025
Merged
Chore/prsd 1519 use complex question page fragment #832
JasminConterioSW
merged 48 commits into
main
from
chore/prsd-1519-use-complex-question-page-fragment
Nov 3, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rs on the page for the skip link
This reverts commit c60c86f
src/main/kotlin/uk/gov/communities/prsdb/webapp/forms/journeys/LandlordRegistrationJourney.kt
Show resolved
Hide resolved
Travis-Softwire
approved these changes
Oct 29, 2025
Collaborator
Travis-Softwire
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few Qs, but LGTM :) Might want to wait to merge until Azure is back up though, as the pipeline will fail otherwise
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket number
PRSD-1519
Goal of change
Update form pages with content before the form components (inputs, submit button) to use the complexQuestionPage fragment (extra content not included in the form)
Description of main change(s)
id=main-contentappears on the<main>section (so it can be found by the "skip to main content" accessiblity linkAnything you'd like to highlight to the reviewer?
This looks like a large review but a lot of the files have been changed in a similar way:
complexQuestionPage.htmlfragment instead of thequestionPage.htmlfragmentquestion-contentblockform-contentblock - only these elements will then be in the sectionFollows the example of the "Interview needs" question page on the design system.
The same pattern is also used in "Check answers" pages on the the design system
Checklist
Delete any that are not applicable, and add explanation below for any that are applicable but haven't been done
and any related functionality)
mention that here