PRSD-1605: Revise async tasks ADR to focus on ad-hoc tasks only #837
+120
−89
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Travis-Softwire
force-pushed
the
feat/prsd-1605-async-tasks-adr-revisit
branch
from
9fbd5ad to
507007e
Compare
rowanhill
approved these changes
Nov 4, 2025
Comment on lines
+62
to
+63
| * Bad, because it would require creating a custom scaling rule for the ECS service, including a lambda function to calculate the metrics, | ||
| which is more complex than using the built-in scaling rules. |
There was a problem hiding this comment.
Don't think this one applies here
| ### Separate long-running ECS task with webserver and private endpoints | ||
|
|
||
| We could run a mirror of our existing ECS service, with a private loadbalancer that is only accessible from within our VPC and endpoints | ||
| that could be targeted by Eventbridge Scheduler. |
There was a problem hiding this comment.
Given this ADR is about on-demand tasks, should these summaries be talking about EventBridge Scheduler? Rather than just vanilla EventBridge or direct queue interaction from the web app? (Although I guess it is true that EventBridge Scheduler could put messages on the queue, too!)
| ## Status | ||
|
|
||
| Superseded | ||
| ACCEPTED |
There was a problem hiding this comment.
Teeny detail, but I don't think any of the other ADRs are using ALL CAPS for status
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket number
PRSD-1605
Goal of change
Updating ADR-0033 to focus on ad-hoc async tasks instead of scheduled tasks (restoring the status of ADR-0029 in respect of the latter
Description of main change(s)
In investigating the proposed architecture for async tasks in the previous verison of ADR-0033 it became clear that it didn't work perfectly for either scheduled tasks or ad-hoc async tasks, and that actually each case had different requirements. Further investigation found that the pattern proposed in ADR-0029 (directly invoking ECS tasks) is commonly used in other services.
This PR revises ADR-0033 to focus more narrowly on ad-hoc async tasks, and concludes that we should (for now, at least) allow the webapp container to handle these.