Feat/prsd 1546 add destination class #840
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AEPR
force-pushed
the
feat/PRSD-1546-add-destination-class
branch
from
3eefa95 to
beb7e89
Compare
Travis-Softwire
approved these changes
Oct 31, 2025
Collaborator
Travis-Softwire
left a comment
Travis-Softwire
left a comment
There was a problem hiding this comment.
A few comments about naming, but agree this looks sensible
src/main/kotlin/uk/gov/communities/prsdb/webapp/journeys/builders/JourneyBuilder.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/uk/gov/communities/prsdb/webapp/journeys/builders/StepInitialiser.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/uk/gov/communities/prsdb/webapp/journeys/example/Destination.kt
Show resolved
Hide resolved
src/main/kotlin/uk/gov/communities/prsdb/webapp/journeys/JourneyStep.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/uk/gov/communities/prsdb/webapp/journeys/StepLifecycleOrchestrator.kt
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket number
PRSD-1546
Goal of change
Use an abstract "destination" class to represent the outcomes of requests. Currently these are steps, urls or pages but this lets us add other outcomes (including a programmatic forward to a non-reachable step).
Checklist
Delete any that are not applicable, and add explanation below for any that are applicable but haven't been done
and any related functionality)