Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix homarr #2369

Merged
merged 47 commits into from
Feb 14, 2025
Merged

Fix homarr #2369

merged 47 commits into from
Feb 14, 2025

Conversation

CrazyWolf13
Copy link
Contributor

✍️ Description

After a lot of work, I present the new approach of installing homarr.

Should be fully compatible with existing approach via update function.

🔗 Related PR / Discussion / Issue

Link: #1952

✅ Prerequisites

Before this PR can be reviewed, the following must be completed:

  • Self-review performed – Code follows established patterns and conventions.
  • Testing performed – Changes have been thoroughly tested and verified.

🛠️ Type of Change

Select all that apply:

  • 🐞 Bug fix – Resolves an issue without breaking functionality.
  • [] ✨ New feature – Adds new, non-breaking functionality.
  • [] 💥 Breaking change – Alters existing functionality in a way that may require updates.
  • [] 🆕 New script – A fully functional and tested script or script set.

📋 Additional Information (optional)

@CrazyWolf13 CrazyWolf13 requested a review from a team as a code owner February 13, 2025 15:26
@github-actions github-actions bot added update script A change that updates a script website A change to the website labels Feb 13, 2025
@CrazyWolf13
Copy link
Contributor Author

Would be awesome if anyone else could actually shortly test it :)

@MickLesk
Copy link
Member

homarr.sh conflicted, remove the lines after my last merge to resolve the conflict

Copy link
Contributor

⚠️ The script ct/homarr.sh failed with the following message:


Attention:
Turborepo now collects completely anonymous telemetry regarding usage.
This information is used to shape the Turborepo roadmap and prioritize features.
You can learn more, including how to opt-out if you'd not like to participate in this anonymous program, by visiting the following URL:
https://turbo.build/repo/docs/telemetry

WARNING no output files found for task @homarr/cli#build. Please check your outputs key in turbo.json
WARNING no output files found for task @homarr/db#build. Please check your outputs key in turbo.json
WARNING no output files found for task @homarr/tasks#build. Please check your outputs key in turbo.json
WARNING no output files found for task @homarr/websocket#build. Please check your outputs key in turbo.json

@CrazyWolf13
Copy link
Contributor Author

@michelroegl-brunner The GH Action should not actually flag this as fail, I think that was just a warn and wasn't even displayed when not using advanced mode

@CrazyWolf13
Copy link
Contributor Author

@MickLesk Yes, just resolved the conflicts :)

Copy link
Contributor

⚠️ The script ct/homarr.sh failed with the following message:


Attention:
Turborepo now collects completely anonymous telemetry regarding usage.
This information is used to shape the Turborepo roadmap and prioritize features.
You can learn more, including how to opt-out if you'd not like to participate in this anonymous program, by visiting the following URL:
https://turbo.build/repo/docs/telemetry

WARNING no output files found for task @homarr/cli#build. Please check your outputs key in turbo.json
WARNING no output files found for task @homarr/db#build. Please check your outputs key in turbo.json
WARNING no output files found for task @homarr/tasks#build. Please check your outputs key in turbo.json
WARNING no output files found for task @homarr/websocket#build. Please check your outputs key in turbo.json

@michelroegl-brunner
Copy link
Member

@michelroegl-brunner The GH Action should not actually flag this as fail, I think that was just a warn and wasn't even displayed when not using advanced mode

i know, but all warnings go against stderr, wich is what i need to capture. Im currently thinking of another way to do it. i guess i have a approch, but it needs more testing. This is why i want to leav it running a bit longer to sample a few case i need to think off.

Copy link
Contributor

⚠️ The script ct/homarr.sh failed with the following message:


Attention:
Turborepo now collects completely anonymous telemetry regarding usage.
This information is used to shape the Turborepo roadmap and prioritize features.
You can learn more, including how to opt-out if you'd not like to participate in this anonymous program, by visiting the following URL:
https://turbo.build/repo/docs/telemetry

WARNING no output files found for task @homarr/cli#build. Please check your outputs key in turbo.json
WARNING no output files found for task @homarr/db#build. Please check your outputs key in turbo.json
WARNING no output files found for task @homarr/tasks#build. Please check your outputs key in turbo.json
WARNING no output files found for task @homarr/websocket#build. Please check your outputs key in turbo.json

@michelroegl-brunner michelroegl-brunner merged commit 1789d18 into community-scripts:main Feb 14, 2025
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
update script A change that updates a script website A change to the website
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants