-
-
Notifications
You must be signed in to change notification settings - Fork 38
Create nic-offloading-fix.sh #310
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Helper script based on the fix found at - https://gist.github.com/crypt0rr/60aaabd4a5c29a256b4f276122765237
If the bug is specific to e1000e, how about perhaps filtering on interfaces that use that? |
Added rx/tx tuning settings
Updated to only filter on |
I cant test it, but we can improve the Script himself. We have an core.func in VED Repo for all colors, spinners, msgs, ... that can you source in, and remove echos and co. |
@MickLesk Thank you ... if you could point to an example script that would be awesome ... I am a few weeks into Proxmox and learning as I go ... thank you for your input. |
Suggestion to make this perhaps even more "bullet-proof": instead of generating one systemd service per interface currently installed, how about generate a single systemd service that checks for every interface using the e1000e driver and disables the offloads for them? That way, even if you (un)install a e1000e interface in the future, you'll still have the offloads properly disabled. And logging stuff on the systemd service and indicating statuses with the return codes for it should work well and be easy to manage/monitor as well. Or perhaps make that an option/alternative to this approach. EDIT: although in this case it gets harder to make the script this user-friendly and have confirmation prompts and all that. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
short comments about sourcing the core.func for colors, variables, msg's ...
@MickLesk @andrebrait Thank you for your detailed feedback ... I will work on your suggestion and detailed help 👍🏻 |
FYI I made this gist based off your MR. Perhaps there are some ideas you might use there: https://gist.github.com/andrebrait/52b22d99f6bdad25cd3f4e1cecd69c15 |
ping @community-scripts/contributor if it ready to merge |
This comment was marked as off-topic.
This comment was marked as off-topic.
Hello, I tested the script and got this error:
What to fix? |
After some testing it seems the issue is with this:
The tx-usecs parameter seems to be not supported?
|
The script probably needs a step to check which, if any, parameters are supported for each detected interface |
@barthoefs Thank you for testing and providing feedback ... I am looking into this and will either fix or remove this feature. |
The original referred to `publuc` not `public`
Should I move this script under |
Clean your PR please ^^ Tools/PVE is the correct path, i can move it everywhere after merge |
I have no clue how to clean a PR so I am going to create a new PR with the 2 files that are required for this and then raise a separate PR for the typo fix for the |
🛑 New scripts must first be submitted to ProxmoxVED for testing.
PRs for new scripts that skip this process will be closed.
✍️ Description
Helper script based on the fix found at - https://gist.github.com/crypt0rr/60aaabd4a5c29a256b4f276122765237.
There is a known issue with Intel NIC e1000e hanging. More details - https://www.reddit.com/r/Proxmox/comments/1drs89s/intel_nic_e1000e_hardware_unit_hang/
This Helper Script has been created to help resolve the issue using the solutions found on GitHub etc. This is not my fix I have just created a Helper Script around the solution that will hopefully help many others.
🔗 Related PR / Issue
Link: N/A
✅ Prerequisites (X in brackets)
🛠️ Type of Change (X in brackets)
README
,AppName.md
,CONTRIBUTING.md
, or other docs.🔍 Code & Security Review (X in brackets)
Code_Audit.md
&CONTRIBUTING.md
guidelinesAppName.sh
,AppName-install.sh
,AppName.json
)📋 Additional Information (optional)