-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Github Action #10
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enable Flake8 & Black
근데 F401이랑 F403 무시해도 지금 flake8이 F405에 대해서 오류를 뿜는데, 이러면 unused import에 대해서 깔끔하게 처리하는게 아님. |
TL;DR : F시리즈 checker만 있고 linter 없으므로 관련 에러 발생 시 코드 리뷰 하는 형식으로 해서 수동으로 fix하기를 제안 F401, F403 ignore 없애기는 ㅇㅋ 근데 import관련이슈들을 linter가 잡는 건 안될 듯? |
comnamu18
added a commit
that referenced
this pull request
Jul 31, 2021
This reverts commit 91fcd23.
comnamu18
added a commit
that referenced
this pull request
Jul 31, 2021
WraithKim
pushed a commit
that referenced
this pull request
Aug 3, 2021
* Update main.yml * Change Base Github Action template * Fix(Lint) automatically * Do not ignore F401, F403 in flake8 reference: https://ljvmiranda921.github.io/notebook/2018/06/21/precommits-using-black-and-flake8/
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
코드 스타일 가이드 관련 깃헙 액션 추가
원래 목적은 unused import 문 black이나 isort로 없애는 거 까지 하려고 하였으나
import를 정적으로 검사하였을 때 생길 수 있는 버그가 있다고 하여 스킵
black이 해주는 기본적인 LINT + 라인 MAX 넘 79
참고링크 : https://ljvmiranda921.github.io/notebook/2018/06/21/precommits-using-black-and-flake8/