ICE Runner #44
Merged
ICE Runner #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sbryngelson is it okay to leave this PR as an ICE runner fix only? Manually installing netcdf-fortran on mac is giving me too much trouble. |
|
Yes and it's useful to have Mac but you could do Ubuntu also, which might be helpful to get started. you can use a virtual machine on your Mac if needed. |
|
Thanks! I would use docker, but my computer doesn't have enough memory to run it without crashing. I'll see if another VM can take up less resources though. |
sbryngelson
approved these changes
Jul 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes in this PR:
I module loaded
netcdf-candhdf5on ICE and used that to buildnetcdf-fortran. Buildingnetcdf-fortranmyself was pretty tough, but I believe my instructions work for a shared library.I also noticed that my tests really aren't comprehensive. The compile steps might be passing but it can still throw link errors at run-time. I handled this in the
CMakeLists.txt(lines 105-108), and it runs without errors on my ICE account, but I'm not sure about other accounts. Tests should probably run code too. Seems like a separate issue that someone should open though.This commit says 100+ lines added, but it's mostly duplicated code. Obviously, there needs to be a top-level install script that can call shell code or cmake to install whatever's necessary for each computer, but that's a lot of restructuring that I will leave for the future.