Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple bug fixes #768

Merged
merged 1 commit into from
Oct 22, 2024
Merged

Conversation

irzamsarfraz
Copy link
Collaborator

  1. Some fixes for testing version of Seurat package (new base R returns a class object for versions instead of just numeric).
  2. One instance of runUMAP had hardcoded initialDims which should not be there.
  3. With newer seurat version convertSCEtoSeurat has some minor issues such as the reducedDim cell names do have hyphen in them when copying non-seurat reducedDim, resulting in errors downstream. I have added a temporary fix in the heatmap function, but eventually it should be fixed in the convertSCEToSeurat function.

Copy link

codecov bot commented Oct 21, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 52.10%. Comparing base (cebf8f2) to head (6155f27).
Report is 2 commits behind head on devel.

Files with missing lines Patch % Lines
R/runDimReduce.R 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##            devel     #768   +/-   ##
=======================================
  Coverage   52.09%   52.10%           
=======================================
  Files          79       79           
  Lines       12983    12985    +2     
=======================================
+ Hits         6764     6766    +2     
  Misses       6219     6219           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@joshua-d-campbell joshua-d-campbell merged commit 6bd11f6 into compbiomed:devel Oct 22, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants