Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add i_water to netcdf output and input #192

Merged
merged 1 commit into from
Nov 1, 2023
Merged

add i_water to netcdf output and input #192

merged 1 commit into from
Nov 1, 2023

Conversation

jcurtis2
Copy link
Collaborator

For simulations being post-processed that were run with CAMP, the index of aerosol water isn't successfully found. This breaks some aspects of the post-processing pipeline (such as drying a particle population or computing critical relative humidities) and (most likely) the cloud parcel model. The issue is that aero_data_input_netcdf reads in all aerosol species names and information but aero_data_set_water_index() won't find water with its current requirements of the string needing an exact match to "H2O" where water in CAMP usually is referred to as something like aqeuous.H2O_aq. PartMC with CAMP enabled relies on the water species having a special entry in the json files of "PartMC name", which then tags the value of aero_data%i_water.

Straight forward solution is to output the value of aero_data%i_water and then also read it in instead searching the names array list.

@jcurtis2 jcurtis2 requested a review from mwest1066 October 29, 2023 18:39
@jcurtis2 jcurtis2 merged commit f871c30 into master Nov 1, 2023
10 checks passed
@jcurtis2 jcurtis2 deleted the add_i_water branch November 1, 2023 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants