Immersion freezing update #205
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remove old directories
remove old directories
remove old directories
remove old directories
remove old directories
remove old directories
Co-authored-by: Jeffrey Curtis <[email protected]>
Co-authored-by: Jeffrey Curtis <[email protected]>
Co-authored-by: Jeffrey Curtis <[email protected]>
Co-authored-by: Jeffrey Curtis <[email protected]>
Co-authored-by: Jeffrey Curtis <[email protected]>
Co-authored-by: Jeffrey Curtis <[email protected]>
Co-authored-by: Jeffrey Curtis <[email protected]>
Co-authored-by: Jeffrey Curtis <[email protected]>
Co-authored-by: Jeffrey Curtis <[email protected]>
Co-authored-by: Jeffrey Curtis <[email protected]>
Co-authored-by: Jeffrey Curtis <[email protected]>
Co-authored-by: Jeffrey Curtis <[email protected]>
Co-authored-by: Jeffrey Curtis <[email protected]>
Co-authored-by: Jeffrey Curtis <[email protected]>
Co-authored-by: Jeffrey Curtis <[email protected]>
Co-authored-by: Jeffrey Curtis <[email protected]>
Co-authored-by: Jeffrey Curtis <[email protected]>
Co-authored-by: Jeffrey Curtis <[email protected]>
Co-authored-by: Jeffrey Curtis <[email protected]>
Co-authored-by: Jeffrey Curtis <[email protected]>
Co-authored-by: Jeffrey Curtis <[email protected]>
jcurtis2
requested changes
Jan 14, 2025
| @@ -25,3 +25,4 @@ scenarios/4_chamber/out | |||
| scenarios/5_coag_brownian/out | |||
| !scenarios/6_camp | |||
| scenarios/6_camp/out | |||
| !scenarios/7_freezing | |||
There was a problem hiding this comment.
Add ignoring scenarios/7_freezing/out
Comment on lines
+134
to
+136
| end program freezing_process | ||
|
|
||
|
|
There was a problem hiding this comment.
Suggested change
| end program freezing_process | |
| end program freezing_process |
Comment on lines
+47
to
+48
| #immersion_freezing_scheme const | ||
| #freezing_rate -.01123456789 |
There was a problem hiding this comment.
Is there a reason to keep these lines?
| do_mosaic no # whether to do MOSAIC (yes/no) | ||
| do_nucleation no # whether to do nucleation (yes/no) | ||
| do_immersion_freezing yes # whether to do freezing (yes/no) | ||
| #immersion_freezing_scheme singular |
| @@ -131,6 +143,10 @@ subroutine aero_particle_zero(aero_particle, aero_data) | |||
| allocate(aero_particle%component(0)) | |||
| aero_particle%least_create_time = 0d0 | |||
| aero_particle%greatest_create_time = 0d0 | |||
| aero_particle%frozen = .FALSE. | |||
There was a problem hiding this comment.
Suggested change
| aero_particle%frozen = .FALSE. | |
| aero_particle%frozen = .false. |
Comment on lines
+202
to
+204
| integer :: loop_count = 0 | ||
|
|
||
|
|
There was a problem hiding this comment.
Appears not needed.
Suggested change
| integer :: loop_count = 0 | |
|
|
||
| !> Simulation for singular scheme, deciding whether to freeze for each | ||
| !> particle. Run in each time step. | ||
| subroutine immersion_freezing_singular(aero_state, aero_data, env_state_initial, env_state_final) |
There was a problem hiding this comment.
env_state_initial is passed here and never used (and if this is correct, env_state_final can just become env_state).
Comment on lines
+166
to
+167
| subroutine immersion_freezing_time_dependent(aero_state, aero_data, env_state_initial, & | ||
| env_state_final, del_t, immersion_freezing_scheme_type, freezing_rate) |
There was a problem hiding this comment.
env_state_initial is passed here and never used (and if this is correct, env_state_final can just become env_state).
Comment on lines
+288
to
+291
| subroutine immersion_freezing_time_dependent_naive(aero_state, aero_data, & | ||
| env_state_initial, env_state_final, del_t, & | ||
| immersion_freezing_scheme_type, & | ||
| freezing_rate) |
There was a problem hiding this comment.
env_state_initial is passed here and never used (and if this is correct, env_state_final can just become env_state).
|
|
||
| !> Simulation for time-dependent scheme (e.g., ABIFM, constant rate), | ||
| !> deciding whether to freeze for each particle. Run in each time step. | ||
| !> This subroutine applys the naive algorithm for reference. |
There was a problem hiding this comment.
Suggested change
| !> This subroutine applys the naive algorithm for reference. | |
| !> This subroutine applies the naive algorithm that checks each particle. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the immersion freezing simulation codes, freezing test case, and freezing scenario.