Update Emscripten instructions to match xeus-cpp in where dependencies are installed from + mount tag files (no longer preloaded in xeus-cpp) #618
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #618 +/- ##
==========================================
+ Coverage 77.66% 77.70% +0.03%
==========================================
Files 9 9
Lines 3743 3749 +6
==========================================
+ Hits 2907 2913 +6
Misses 836 836 🚀 New features to boost your workflow:
|
mcbarton
force-pushed
the
Update-build-instructions-xeus-cpp
branch
from
20e51ed to
340243c
Compare
…ok libarchive-c to be consistent with ci)
mcbarton
force-pushed
the
Update-build-instructions-xeus-cpp
branch
from
8b806df to
d78b848
Compare
|
This PR is ready for review now. With the latest change to xeus-cpp, the tagfiles are mounted to the jupyter lite build instead of preloaded. Without that change to CppInterOps ci, part of the deployment will be broken after the next nightly build. |
|
Looks good to me but let's have another pair of eyes. |
mcbarton
changed the title
anutosh491
reviewed
Jun 12, 2025
anutosh491
approved these changes
Jun 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of changes, motivation and context for this PR.
Fixes # (issue)
Type of change
Please tick all options which are relevant.
Testing
Please describe the test(s) that you added and ran to verify your changes.
Checklist