Skip to content

Update Emscripten instructions to match xeus-cpp in where dependencies are installed from + mount tag files (no longer preloaded in xeus-cpp) #618

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

mcbarton
Copy link
Collaborator

@mcbarton mcbarton commented Jun 6, 2025

Description

Please include a summary of changes, motivation and context for this PR.

Fixes # (issue)

Type of change

Please tick all options which are relevant.

  • Bug fix
  • New feature
  • Requires documentation updates

Testing

Please describe the test(s) that you added and ran to verify your changes.

Checklist

  • I have read the contribution guide recently

Copy link

codecov bot commented Jun 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.70%. Comparing base (3d3c82d) to head (35052db).
Report is 7 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #618      +/-   ##
==========================================
+ Coverage   77.66%   77.70%   +0.03%     
==========================================
  Files           9        9              
  Lines        3743     3749       +6     
==========================================
+ Hits         2907     2913       +6     
  Misses        836      836              

see 1 file with indirect coverage changes

see 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mcbarton mcbarton requested a review from vgvassilev June 6, 2025 14:08
@mcbarton mcbarton force-pushed the Update-build-instructions-xeus-cpp branch from 20e51ed to 340243c Compare June 6, 2025 14:24
@mcbarton mcbarton force-pushed the Update-build-instructions-xeus-cpp branch from 8b806df to d78b848 Compare June 9, 2025 08:37
@mcbarton
Copy link
Collaborator Author

This PR is ready for review now. With the latest change to xeus-cpp, the tagfiles are mounted to the jupyter lite build instead of preloaded. Without that change to CppInterOps ci, part of the deployment will be broken after the next nightly build.

@vgvassilev vgvassilev requested a review from anutosh491 June 11, 2025 19:13
@vgvassilev
Copy link
Contributor

Looks good to me but let's have another pair of eyes.

@mcbarton mcbarton changed the title Update Emscripten instructions to match xeus-cpp (+ jupyterlab notebook libarchive-c to be consistent with ci) Update Emscripten instructions to match xeus-cpp in where dependencies are installed from + mount tag files (no longer preloaded in xeus-cpp) Jun 11, 2025
@mcbarton mcbarton merged commit f1c3ed9 into compiler-research:main Jun 12, 2025
49 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants