Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: implement "Ready to work together?" section of /our-work page #221

Merged
merged 1 commit into from
Jul 1, 2024

Conversation

lalver1
Copy link
Member

@lalver1 lalver1 commented Jun 28, 2024

Closes #214

@lalver1 lalver1 self-assigned this Jun 28, 2024
@lalver1 lalver1 changed the title Feat: implement Ready to work together? section of /our-work page Feat: implement "Ready to work together?" section of /our-work page Jun 28, 2024
@lalver1 lalver1 added this to the Work Page milestone Jun 28, 2024
@lalver1 lalver1 linked an issue Jun 28, 2024 that may be closed by this pull request
@lalver1 lalver1 marked this pull request as ready for review June 28, 2024 20:43
@lalver1 lalver1 requested a review from a team as a code owner June 28, 2024 20:43
@lalver1 lalver1 force-pushed the feat/ready-to-work branch from b17321d to 9f4bd42 Compare July 1, 2024 14:09
Copy link
Member

@thekaveman thekaveman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be possible to use an include here? Then we can have a single block used for /about and /our-work?

@lalver1 lalver1 force-pushed the feat/ready-to-work branch from 9f4bd42 to 299c000 Compare July 1, 2024 21:16
@lalver1
Copy link
Member Author

lalver1 commented Jul 1, 2024

Yep, that's a good point 👍
I used an include with a parameter to set the color of the text (because the background of the section in /our-work is black but it is white in /about) and a conditional tag to set the class.

I could remove the conditional by using the default filter:

<h3 class="{{ include.h3-class | default: "" }}">Ready to work together?</h3>

but having <h3 class="">Ready to work together?</h3> in the rendered HTML of /our-work didn't look right.

The include would be much simpler if the background of the section was the same for both /about and /our-work (no parameters to pass or any conditional tags) but I'm not sure if we should deviate from what we have in Figma?

@lalver1 lalver1 force-pushed the feat/ready-to-work branch from 299c000 to 2ce57b3 Compare July 1, 2024 21:18
@thekaveman
Copy link
Member

I think this is fine. It can be more flexible to avoid sending the specific class as part of the configuration, maybe instead a light or dark mode where the include then decides which classes to use etc.

But this will work and we can always revisit when we need to use this component again.

@lalver1 lalver1 merged commit 96f6f0b into feat/our-work Jul 1, 2024
1 check passed
@lalver1 lalver1 deleted the feat/ready-to-work branch July 1, 2024 23:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add "Ready to work together?" section
2 participants