Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: "What We've Done" - last two cards #228

Merged
merged 4 commits into from
Jul 10, 2024

Conversation

angela-tran
Copy link
Member

Part of #212

This PR adds the last two cards to the "What We've Done" section.

The min-height styles for card content alignment needed to be tweaked a little bit so that the "description" paragraphs would also be aligned as shown in Figma.

Before tweaks in 2764070 After 2764070 Figma
image image image

Builds off the branch for #224

@angela-tran angela-tran added this to the Work Page milestone Jul 9, 2024
@angela-tran angela-tran self-assigned this Jul 9, 2024
Base automatically changed from feat/what-weve-done--image-cards to feat/our-work July 9, 2024 22:06
@angela-tran angela-tran force-pushed the feat/what-weve-done--last-two-cards branch from d7b05e0 to ee0a075 Compare July 9, 2024 22:22
@angela-tran angela-tran marked this pull request as ready for review July 9, 2024 22:23
@angela-tran angela-tran requested a review from a team as a code owner July 9, 2024 22:23
Copy link
Member

@machikoyasuda machikoyasuda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! like the approach


- title: Product Schedule
description: Managed a research project to evaluate how well scheduling software solutions met the needs of small and rural California transit agencies. Research included conducting 30+ hours of onsite interviews with 4 agencies.
outcome: Deliver a research report to CalTrans summarizing research results and recommending actionable next steps to solution providers and CalTrans to provide agencies with vital scheduling resources.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Caltrans not CalTrans

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a note: Product Schedule's Outcome section is present (deliver) tense but the rest are past tense (launched).

Copy link
Member

@thekaveman thekaveman Jul 10, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's just make these changes (Caltrans and past tense) 👍

@@ -32,3 +32,17 @@
- Project Management
- Human-centered Design
- Software Development

- title: Upgrade Scenario Planning Model (SPM)
description: Collaborated with a diverse team to update and enhance the SPM transportation model by developing database queries and a user interface for the Southern California Association of Governments (SCAG).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SCAG is mentioned in the Data+Donuts section without spelling it out, but the D+D section comes above this one. Sooo... ideally the D+D section spells out Southern California Association of Governments (SCAG) as it's the first reference on the page, and the rest following can just be SCAG.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep I think this change makes sense

@machikoyasuda machikoyasuda self-requested a review July 9, 2024 23:15
Copy link
Member

@machikoyasuda machikoyasuda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good but there are a few small copy issues, see comments

@machikoyasuda machikoyasuda self-requested a review July 9, 2024 23:40
Copy link
Member

@machikoyasuda machikoyasuda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for all the back and forth - the code looks good. I think the Copy needs to be reviewed in entirety once this whole page is done and in one single PR.

@thekaveman
Copy link
Member

I think the Copy needs to be reviewed in entirety once this whole page is done and in one single PR.

This sounds good to me 👍

@@ -32,3 +32,17 @@
- Project Management
- Human-centered Design
- Software Development

- title: Upgrade Scenario Planning Model (SPM)
description: Collaborated with a diverse team to update and enhance the SPM transportation model by developing database queries and a user interface for the Southern California Association of Governments (SCAG).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep I think this change makes sense

@angela-tran angela-tran merged commit 4725a03 into feat/our-work Jul 10, 2024
1 check passed
@angela-tran angela-tran deleted the feat/what-weve-done--last-two-cards branch July 10, 2024 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants