Merge pull request #579 from codaco/fix/sociogram-prompt-editing

Fix sociogram prompt editing
complexdatacollective · Sep 19, 2019 · ce8dd3b · ce8dd3b
2 parents 675ed61 + 05f9026
commit ce8dd3b
Show file tree

Hide file tree

Showing 3 changed files with 17 additions and 8 deletions.
diff --git a/src/components/EditableList/withEditHandlers.js b/src/components/EditableList/withEditHandlers.js
@@ -35,11 +35,10 @@ const mapDispatchToProps = (dispatch, { form }) => ({
 });
 
 const mapItemStateToProps = (state, { form, itemSelector, editField, template }) => {
-  const item = formValueSelector(form)(state, editField);
+  const item = itemSelector(state, { form, editField });
+  const initialValues = item || { ...template(), id: uuid() };
 
-  if (!item) { return { initialValues: { ...template(), id: uuid() } }; }
-
-  return { initialValues: itemSelector(state, item) };
+  return { initialValues };
 };
 
 const stateHandlers = withStateHandlers(

diff --git a/src/components/sections/CategoricalBinPrompts/helpers.js b/src/components/sections/CategoricalBinPrompts/helpers.js
@@ -1,9 +1,14 @@
 /* eslint-disable import/prefer-default-export */
 
+import { formValueSelector } from 'redux-form';
 import { getOptionsForVariable } from '../../../selectors/codebook';
 
 export const itemSelector = (entity, type) =>
-  (state, prompt) => {
+  (state, { form, editField }) => {
+    const prompt = formValueSelector(form)(state, editField);
+
+    if (!prompt) { return null; }
+
     const variableOptions = getOptionsForVariable(
       state,
       { entity, type, variable: prompt.variable },

diff --git a/src/components/sections/Form/helpers.js b/src/components/sections/Form/helpers.js
@@ -1,4 +1,5 @@
 
+import { formValueSelector } from 'redux-form';
 import { omit, get, reduce } from 'lodash';
 import { getVariablesForSubject } from '../../../selectors/codebook';
 
@@ -23,15 +24,19 @@ export const normalizeField = field =>
 
 // Merge item with variable info from codebook
 export const itemSelector = (entity, type) =>
-  (state, prompt) => {
-    const variable = prompt.variable;
+  (state, { form, editField }) => {
+    const item = formValueSelector(form)(state, editField);
+
+    if (!item) { return null; }
+
+    const variable = item && item.variable;
 
     const codebookVariables = getVariablesForSubject(state, { entity, type });
     const codebookVariable = get(codebookVariables, variable, {});
     const codebookProperties = getCodebookProperties(codebookVariable);
 
     return {
-      ...prompt,
+      ...item,
       ...codebookProperties,
     };
   };