Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update inctances of trackEvent #60

Merged
merged 6 commits into from
Feb 1, 2024

Conversation

mrkarimoff
Copy link
Contributor

This PR updates every use case of trackEvent to adjust to the new error type of analytics package (error is a type of JS Error and also supports additional metadata property

Copy link

vercel bot commented Jan 25, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
fresco ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 1, 2024 8:09am

@mrkarimoff mrkarimoff marked this pull request as ready for review January 25, 2024 11:36
@mrkarimoff mrkarimoff requested a review from jthrilly January 25, 2024 11:36
Copy link
Member

@jthrilly jthrilly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving for now. I'm going to update trackEvent separately for better error handling when analytics fails.

@jthrilly jthrilly merged commit 9e8f436 into main Feb 1, 2024
5 checks passed
@jthrilly jthrilly deleted the refactor/analytics-trackevent-invocations branch March 28, 2024 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants