Fix: Interview translation types inference #61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
jthrilly
reviewed
Sep 20, 2024
components/interview/interfaces/name-generator/NameGenerator.tsx
Outdated
Show resolved
Hide resolved
jthrilly
reviewed
Sep 20, 2024
uses protocol messages schema to infer a type that next-intl uses. replaces generic AbstractIntlMessages with specific types when loading messagess
jthrilly
reviewed
Sep 25, 2024
also make Prompts extend html div element
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sets up getting type inference when using useTranslations in interview components where the messages aren't predefined and the ids are dynamic.
Accomplished by adding ProtocolMessages type to the IntlMessages type.