Replace Maxmind with IP-API #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simpler and does not require api or account. this allows us to remove utiliation of maxmind client and perform geo location from analytics package directly
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
2 tasks
jthrilly
approved these changes
Feb 20, 2024
| if(geoData.status === "success") { | ||
| countryISOCode = geoData.countryCode; | ||
| } else { | ||
| throw new Error(geoData.message); |
There was a problem hiding this comment.
I think we probably want to specifically check for the 429 response code so we can log something else if we are throttled.
| @@ -26,7 +26,7 @@ importers: | |||
| version: link:packages/tsconfig | |||
| turbo: | |||
| specifier: latest | |||
| version: 1.12.2 | |||
| version: 1.10.16 | |||
There was a problem hiding this comment.
weird that this got downgraded...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Geo location provider
maxmindhas a complicated workflow to set up an account and get theirMAXMIND_ACCOUNT_IDandMAXMIND_LICENSE_KEY. Team decided to replace Maxmind with an alternative way to get country code from IP address that does not require users to create accounts or generate API keys.IP-API provides a free geolocation API with no API key or account setup required. This PR replaces maxmind with ip-api. This allows us to move IP geolocation within the analytics package directly and remove it from Fresco in PR #81
Before merge: