Make bic optional, bump version to 0.1.1

compliance-innovations · Sep 16, 2019 · 122a219 · 122a219
1 parent 641687a
commit 122a219
Show file tree

Hide file tree

Showing 5 changed files with 9 additions and 3 deletions.
diff --git a/.gitignore b/.gitignore
@@ -9,3 +9,5 @@
 
 #JetBrains IDEs
 /.idea/
+
+*.gem
diff --git a/.ruby-version b/.ruby-version
@@ -0,0 +1 @@
+2.5.3
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -0,0 +1,3 @@
+# 0.1.1 - 2019-09-16
+- bugfixes
+  - BIC fields are now optional
diff --git a/lib/sepa_parser.rb b/lib/sepa_parser.rb
@@ -26,11 +26,11 @@ def self.parse(data) # rubocop:disable MethodLength, AbcSize
                                 get_element_text(document, 'Document/CstmrCdtTrfInitn/PmtInf/Dbtr/Nm'),
                                 get_element_text(document, 'Document/CstmrCdtTrfInitn/PmtInf/DbtrAcct/Id/IBAN'),
                                 get_element_text_if_exists(document, 'Document/CstmrCdtTrfInitn/PmtInf/DbtrAcct/Ccy'),
-                                get_element_text(document, 'Document/CstmrCdtTrfInitn/PmtInf/DbtrAgt/FinInstnId/BIC'),
+                                get_element_text_if_exists(document, 'Document/CstmrCdtTrfInitn/PmtInf/DbtrAgt/FinInstnId/BIC'),
                                 get_element_text(transfer, 'PmtId/EndToEndId'),
                                 get_element_text(transfer, 'Amt/InstdAmt'),
                                 get_element_attribute(transfer, 'Amt/InstdAmt', 'Ccy'),
-                                get_element_text(transfer, 'CdtrAgt/FinInstnId/BIC'),
+                                get_element_text_if_exists(transfer, 'CdtrAgt/FinInstnId/BIC'),
                                 get_element_text(transfer, 'Cdtr/Nm'),
                                 get_element_text(transfer, 'CdtrAcct/Id/IBAN'),
                                 get_element_text_if_exists(transfer, 'CdtrAcct/Ccy'),

diff --git a/lib/sepa_parser/version.rb b/lib/sepa_parser/version.rb
@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module SepaParser
-  VERSION = '0.1.0'
+  VERSION = '0.1.1'
 end