Skip to content

Commit

Permalink
Remove min-height rule from CodeListing. (swiftlang#718)
Browse files Browse the repository at this point in the history
This causes issues when code listings are used in `@Row`/`@Col` DocC
directives, because it results in them expanding beyond their normal
size and potentially obscures content below the row.

It doesn't seem that the `min-height` rule is still needed with the
recent updates to the styling of code listings whereas it was previously
used to fix an issue with overflow scrolling in tutorial code.

Resolves: rdar://112272083
  • Loading branch information
mportiz08 committed Jul 25, 2023
1 parent c142759 commit 3dfc583
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion src/components/ContentNode/CodeListing.vue
Original file line number Diff line number Diff line change
Expand Up @@ -184,7 +184,6 @@ code {
.code-listing {
flex-direction: column;
min-height: 100%;
border-radius: var(--code-border-radius, $border-radius);
overflow: hidden;
// we need to establish a new stacking context to resolve a Safari bug where
Expand Down

0 comments on commit 3dfc583

Please sign in to comment.