don't check project name if validation is skipped #750
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
PR Overview
This PR updates the behavior for project name validation by skipping the check when validation is not required.
- Modify the project name emptiness check to only perform when SkipValidation is false
- Ensure that the file loader/loader.go correctly adheres to the updated condition
Reviewed Changes
| File | Description |
|---|---|
| loader/loader.go | Adjusts the project name check to only enforce it when validation is not skipped |
Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.
Signed-off-by: Nicolas De Loof <[email protected]>
glours
approved these changes
Mar 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.