Remove support for nvidia driver capabilities #798
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
true, still other capabilities could be required to select the adequate device. |
This chanage updates the device spec to allow for a driver OR capabilities to be specified. It also removes the NVIDIA capabilitied from the documentation of the gpus.capabilities field. Signed-off-by: Evan Lezar <[email protected]>
elezar
force-pushed
the
remove-nvidia-capabilities
branch
from
d498a2d to
9a8a484
Compare
Thanks for pointing this out. I have updated the PR to not remove the field, but to update the documentation for the field to not refer to the nvidia-specific capabilities. |
ndeloof
approved these changes
Jun 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This chanage updates the device spec to allow for a driver OR capabilities to be specified. It also removes the capabilities from the gpu spec and indicates that the gpu capability is implied.