Move solc from optional to dev dependency and update Slueth interface #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… to allow users to pass in solc.compile function.
hayesgm
reviewed
Aug 15, 2023
| } | ||
|
|
||
| query<T>(q: string): Query<T, []> { | ||
| let registrations = this.sources.map((source) => { | ||
| let iface = JSON.stringify(source.iface.format(FormatTypes.full)); | ||
| let iface = JSON.stringify(source.iface.format(FormatTypes.full)); |
There was a problem hiding this comment.
Should this indent be here?
| @@ -20,9 +23,8 @@ | |||
| }, | |||
| "dependencies": { | |||
| "@ethersproject/contracts": "^5.7.0", | |||
| "@ethersproject/providers": "^5.7.2" | |||
| "@ethersproject/providers": "^5.7.2", | |||
| "solc": "^0.8.21" | |||
There was a problem hiding this comment.
This feels like it should be even less here?
| throw new Error(`solc.js yarn dependency not found. Please build with optional dependencies included`); | ||
| function solcCompile( | ||
| input: SolcInput, | ||
| compileFn: ((input: string) => string) | undefined |
There was a problem hiding this comment.
I really think this should be async, which would be a way more common way to use it (e.g. via a WebWorker)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Users to wish to use solc will now need to pass in the solc.compile() function depending on how they use the API.