Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding delete button for exams #50

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Adding delete button for exams #50

wants to merge 3 commits into from

Conversation

jasonkhoe
Copy link
Contributor

def destroy
exam_dir = 'public/examfiles/'
@exam = Exam.find(params[:id])
exam_path = exam_dir+ @exam.filename
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

exam_path = exam_dir + @exam.filename

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, file paths should probably be joined with File.join.

ochan1 pushed a commit to ochan1/hkn-rails that referenced this pull request Feb 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants