MMB-271: Add Certificate Validity Date Tokens #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shahrukh-compuco
force-pushed
the
MMB-271-add-min-max-date-tokens
branch
from
ddcffc4
to
2ad7abb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Add two new tokens for certificate validity dates
“Valid From Date” {certificate.valid_from}
The latter of 1) the “Min Valid From Date” as configured for the certificate and 2) the users membership start date.
If the “Min Valid From Date” is null then we use the membership start date.
“Valid To Date” {certificate.valid_to}
The earlier of 1) the “Max Valid Through Date” as configured for the certificate and 2) the users membership end date.
If the “Max Valid Through Date” is null then we use the membership end date.
Before
There were no certificate validity tokens.
After