MMB-272: Add Validity Dates Check For Certificate Download

[shahrukh-compuco]

Overview

Add checks for validity dates during the certificate download i.e if contacts membership is valid between the min and max validity dates then only the certificate gets downloaded otherwise an error message is shown to the user.

Before

N/A

After

The check works in following ways

1. If the membership start date is before or equal (<=) to the “Max Valid Through Date” of the certificate then the user should have access. Otherwise deny access. If the Max Valid Through Date is null, this test can be disregarded.

AND

2. If the membership end date is after or equal (>=) the “Min Valid From Date “ , the user should have access to the certificate. Otherwise deny access. If the Min Valid From Date is null, this test can be disregarded.

[olayiwola-compucorp]

@shahrukh-compuco; I dont think this check checkMembershipDates() is needed.

The system should work in such a way that if the membership date does not meet the expected criteria, the user won't get the link at all.

You can simply see how we check for conditions like membership status here https://github.com/compucorp/uk.co.compucorp.certificate/blob/13e662cfe0c0424b929782fd7512e7ebc444ced0/CRM/Certificate/Entity/Membership.php#L132C3-L132C102