MMB-284: Handle Multiple Current Memberships #83
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -65,16 +71,63 @@ public function prefetch(TokenValueEvent $e) { | |||
| return $resolvedTokens; | |||
| } | |||
|
|
|||
| private function getMembershipDates(TokenValueEvent $e): array { | |||
There was a problem hiding this comment.
Hi, @shahrukh-compuco Given that these new tokens are related to the membership entity, I believe they are better moved to and resolved in the membership token class https://github.com/compucorp/uk.co.compucorp.certificate/blob/master/CRM/Certificate/Token/Membership.php
There was a problem hiding this comment.
Hey Ola
As discussed that there might be a new ticket from Pallavi to transfer all the work to membership type only, I think then not only this but other work in this workstream will be transffered at once to the membership classes
shahrukh-compuco
force-pushed
the
MMB-284-multiple-current-memberships
branch
from
d814f20
to
66dea7d
Compare
olayiwola-compucorp
approved these changes
Nov 27, 2023
|
PR approved with the note that the highlighted issues will be addressed in a separate PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Handle multiple active memberships for a contact while evaluating the token values in such a way that the earliest start date and lattest end date is selected from all the currently active memberships.
Before
N/A
After
N/A