COMCL-722: Allow user with award review permission access option value #283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olayiwola-compucorp
force-pushed
the
COMCL-722-allow-award-review-access-optionvalue
branch
from
1bf06f3
to
4c84978
Compare
shahrukh-compuco
approved these changes
Sep 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Allow users with award review permission access option value
Before
After
Technical Details
Previously a non-admin user wasn't able to access the options of a custom filed if the options were from an option value, this is because the options are retrieved using apiv4 which non-CCCRM user roles do not have access to.
In this PR we now explicitly grant access to option values on the Award review form for non-CiviCRM users with review award permission.