BTHAB-180: Only perform delete if id line item is not empty

compucorp · Sep 11, 2023 · 54f2773 · 54f2773
1 parent 400e7d9
commit 54f2773
Showing 1 changed file with 6 additions and 2 deletions.
diff --git a/Civi/Api4/Action/CaseSalesOrder/SalesOrderSaveAction.php b/Civi/Api4/Action/CaseSalesOrder/SalesOrderSaveAction.php
@@ -2,12 +2,12 @@
 
 namespace Civi\Api4\Action\CaseSalesOrder;
 
+use CRM_Civicase_BAO_CaseSalesOrder as CaseSalesOrderBAO;
 use CRM_Core_Transaction;
-use Civi\Api4\Generic\Result;
 use Civi\Api4\CaseSalesOrderLine;
+use Civi\Api4\Generic\Result;
 use Civi\Api4\Generic\AbstractSaveAction;
 use Civi\Api4\Generic\Traits\DAOActionTrait;
-use CRM_Civicase_BAO_CaseSalesOrder as CaseSalesOrderBAO;
 
 /**
  * {@inheritDoc}
@@ -87,6 +87,10 @@ public function removeStaleLineItems(array $salesOrder) {
 
     $lineItemsInUse = array_column($salesOrder['items'], 'id');
 
+    if (empty($lineItemsInUse)) {
+      return;
+    }
+
     CaseSalesOrderLine::delete()
       ->addWhere('sales_order_id', '=', $salesOrder['id'])
       ->addWhere('id', 'NOT IN', $lineItemsInUse)