BTHA-188: Avoid calculating opportunity detail for deleted contribution

compucorp · Aug 19, 2024 · e4f38f7 · e4f38f7
1 parent ad19a83
commit e4f38f7
Showing 1 changed file with 4 additions and 1 deletion.
diff --git a/CRM/Civicase/Service/CaseSalesOrderOpportunityCalculator.php b/CRM/Civicase/Service/CaseSalesOrderOpportunityCalculator.php
@@ -172,7 +172,10 @@ private function calculateOpportunityFinancialAmount($contributions) {
   private function getContributions($caseId) {
     $contributions = Contribution::get(FALSE)
       ->addSelect('*', 'Opportunity_Details.Quotation')
-      ->addWhere('Opportunity_Details.Case_Opportunity', '=', $caseId);
+      ->addWhere('Opportunity_Details.Case_Opportunity', '=', $caseId)
+      ->addJoin('CaseSalesOrder AS case_sales_order', 'INNER',
+        ['Opportunity_Details.Quotation', '=', 'case_sales_order.id']
+      );
 
     if ($this->deletingContributionId !== NULL) {
       $contributions->addWhere('id', '!=', $this->deletingContributionId);