Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FOSFA-283: Resolve issue with case tokens not resolved via webform #1012

Merged
merged 3 commits into from
May 30, 2024

Conversation

olayiwola-compucorp
Copy link

Context

Following the resolution of the issue with case tokens not being resolved in PR #789, it was noted that the solution implemented did not encompass scenarios where the email is triggered outside the CiviCRM context, such as cases created through webform submissions. This PR addresses this gap by refining the logic for evaluating case roles and custom field tokens. Regardless of how the case is created and the email is triggered, the tokens' values are now appropriately evaluated.

Template

Below is the template containing a case token, case custom field token, and case role token.

Case ID {case.id}

Argo card {case_cf.custom_175}

Role {case_roles.client_display_name}

Before

Previously, only the case token was resolved.

Before Screenshot

After

Now, all token categories are resolved appropriately.

After Screenshot

We have rewritten the logic to evaluate case roles and custom fields tokens such that irrespective of how the case is creeated and email is triggered the tokens value are evaluated appropraitely
We are removing this test given that the case custom field token resolve logic has changed
@olayiwola-compucorp olayiwola-compucorp merged commit ccc6848 into master May 30, 2024
2 checks passed
@olayiwola-compucorp olayiwola-compucorp deleted the FOSFA-283-customfield-tokens branch May 30, 2024 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants