Fix type mismatch in CaseStatus.getLabelsForValues #377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes a typing issue in CaseStatus.getLabelsForValues:
caseStatus.value appears to be a string, and statusValue may be either
int or string depending on where it is passed from ("Go to case" vs.
case filter). This casts both values to int before strict comparison.
pfigel
force-pushed
the
fix-case-status-value-comparison
branch
from
a52aaa4
to
63f9bd9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Fix a type mismatch in
CaseStatus.getLabelsForValuesBefore
String
caseStatus.valueis tested for strict equality withstatusValue, which may be either String or Integer (e.g. when opening a case via "Go to case" vs. using case filters).After
String
caseStatus.valueandstatusValueis cast to Integer before comparison.