Fix installation on a multilingual install #536
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @mlutfy, sorry for the slow reply. I'll bring this issue to our team meeting this Thursday so we can allocate QA time to properly text this fix and see if there are any other related issues. Thanks for pointing this out. |
|
@tunbola @james-compucorp just thought I'd flag this as we have a ready patch which looks like it fixes? Best |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Result: fatal error (DB error)
Technical Details
In multilingual, CiviCRM does automatic renaming of tables names so that queries run on the language-specific SQL views.
The
getTableName()function on DAOs will return the localized table name.This patch is a workaround. An alternative would be to hardcode the SQL table name instead of calling the DAO's getTableName().