Remove ad-hoc client-side variable in favor of the one already available #795
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tunbola I'd like to do a larger cleanup for Angular best practices - to avoid merge conflicts can you go ahead & merge this one first, it should be a no-brainer. |
|
Thanks @colemanw. One of the places was missed, thats why the unit tests are failing. Please fix this aswell. |
CiviCRM core already sets `CRM.config.cid` so there is no need to reinvent it.
|
@deb1990 it's passing now. |
deb1990
approved these changes
May 27, 2021
|
This has been sent for QA, just to be sure that it is not producing any regressions. Will update soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
CiviCRM core already sets
CRM.config.cidso there is no need to reinvent it.Before
This extension sets a custom client-side variable with current user cid.
After
Just use the one that's already there.
Comments
It's been available in Core since 2019:
https://github.com/civicrm/civicrm-core/blob/2daeb956defabc57f2ea517dec4a793a4ec283b8/templates/CRM/common/l10n.js.tpl#L21