Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GIZ-348: Remove tabsactivate event listener for Contact Summary tabs #958

Merged
merged 1 commit into from
Jul 13, 2023

Conversation

deb1990
Copy link

@deb1990 deb1990 commented Jul 13, 2023

Overview

In Contact Summary Record Page, if multiple tabs that depend on angular is clicked within a short time, the browser was getting frozen and about 2000 network requests are sent.

Before

Browser was freezing and 2000 network requests are getting sent.
before

After

Browser is not getting frozen and unusual requests are not being sent.
after

Technical Details

Details of the solution is added to the code itself.

@deb1990 deb1990 force-pushed the GIZ-348-fix-for-high-number-requests branch from 008893f to b0ca67f Compare July 13, 2023 08:28
@deb1990 deb1990 force-pushed the GIZ-348-fix-for-high-number-requests branch from b0ca67f to c38540f Compare July 13, 2023 08:30
@deb1990
Copy link
Author

deb1990 commented Jul 13, 2023

There is a test failing, but its not related to my changes. So probably its an existing issue?

@olayiwola-compucorp
Copy link

olayiwola-compucorp commented Jul 13, 2023

There is a test failing, but its not related to my changes. So probably its an existing issue?

HeadlessChrome 105.0.5195 (Linux 0.0.0) GoToWebformCaseAction when clicking on the webform shows an information popup to refresh the page FAILED
	TypeError: Cannot read properties of undefined (reading 'replace')
	    at GoToWebformCaseAction.doAction (tools/extensions/uk.co.compucorp.civicase/ang/civicase/case/actions/services/go-to-webform-case-action.service.js:38:13 <- tools/extensions/uk.co.compucorp.civicase/ang/civicase/case/actions/services/go-to-webform-case-action.service.js:11:554)
	    at UserContext.<anonymous> (tools/extensions/uk.co.compucorp.civicase/ang/test/civicase/case/actions/services/go-to-webforms-case-action.service.spec.js:64:31)
	    at <Jasmine>

@deb1990

@olayiwola-compucorp olayiwola-compucorp merged commit c2d8796 into master Jul 13, 2023
1 of 2 checks passed
@olayiwola-compucorp olayiwola-compucorp deleted the GIZ-348-fix-for-high-number-requests branch July 13, 2023 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants